Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accounts/abi/bind/backends: make suggestGP compatible with non-1559 chains #23840

Merged
merged 1 commit into from
Nov 1, 2021
Merged

accounts/abi/bind/backends: make suggestGP compatible with non-1559 chains #23840

merged 1 commit into from
Nov 1, 2021

Conversation

MariusVanDerWijden
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden commented Nov 1, 2021 •
edited
Loading

follow up to #23836

Makes suggestGasPrice behave properly even if the header has no basefee (pre-eip1559)
This should not actually happen as the SimulatedBackend has AllEthashChanges build in, but it's more correct imo.

holiman
holiman approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman added this to the 1.10.12 milestone Nov 1, 2021
@holiman holiman merged commit c2e64db into ethereum:master Nov 1, 2021
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Nov 1, 2021
@MariusVanDerWijden
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
0b8527a 
…1559 chains (ethereum#23840)
@MariusVanDerWijden MariusVanDerWijden deleted the sim-backend-suggestgp branch November 30, 2021 15:34
This was referenced Sep 23, 2022
Closed
Merged
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
@MariusVanDerWijden @zzyalbert
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
931b251 
…1559 chains (ethereum#23840)
@gzliudan gzliudan mentioned this pull request May 17, 2024
Merged
19 tasks
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 2, 2024
@MariusVanDerWijden @gzliudan
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
1b336fc 
…1559 chains (ethereum#23840)
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 6, 2024
@MariusVanDerWijden @gzliudan
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
33a3994 
…1559 chains (ethereum#23840)
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@MariusVanDerWijden @gzliudan
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
9d241f5 
…1559 chains (ethereum#23840)
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@MariusVanDerWijden @gzliudan
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
d85a343 
…1559 chains (ethereum#23840)
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@MariusVanDerWijden @gzliudan
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
5b5913d 
…1559 chains (ethereum#23840)
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 10, 2024
@MariusVanDerWijden @gzliudan
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
3e058df 
…1559 chains (ethereum#23840)
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@MariusVanDerWijden @gzliudan
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
78d3b31 
…1559 chains (ethereum#23840)
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@MariusVanDerWijden @gzliudan
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
a3eb0c6 
…1559 chains (ethereum#23840)
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@MariusVanDerWijden @gzliudan
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
453711f 
…1559 chains (ethereum#23840)
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@MariusVanDerWijden @gzliudan
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
e94ccf9 
…1559 chains (ethereum#23840)
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@MariusVanDerWijden @gzliudan
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
029a39d 
…1559 chains (ethereum#23840)
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 21, 2024
@MariusVanDerWijden @gzliudan
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
d5b92c1 
…1559 chains (ethereum#23840)
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@MariusVanDerWijden @gzliudan
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
d7260ce 
…1559 chains (ethereum#23840)
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@MariusVanDerWijden @gzliudan
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
0d3b702 
…1559 chains (ethereum#23840)
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@MariusVanDerWijden @gzliudan
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
fb2658c 
…1559 chains (ethereum#23840)
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@MariusVanDerWijden @gzliudan
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
91e131e 
…1559 chains (ethereum#23840)
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@MariusVanDerWijden @gzliudan
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
7fcc101 
…1559 chains (ethereum#23840)
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@MariusVanDerWijden @gzliudan
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
72162d1 
…1559 chains (ethereum#23840)
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 27, 2024
@MariusVanDerWijden @gzliudan
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
20b6641 
…1559 chains (ethereum#23840)
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Oct 9, 2024
@MariusVanDerWijden @gzliudan
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
8d0d897 
…1559 chains (ethereum#23840)
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Oct 17, 2024
@MariusVanDerWijden @gzliudan
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
0a3e46e 
…1559 chains (ethereum#23840)
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Oct 18, 2024
@MariusVanDerWijden @gzliudan
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
da15303 
…1559 chains (ethereum#23840)
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Oct 25, 2024
@MariusVanDerWijden @gzliudan
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
ab11655 
…1559 chains (ethereum#23840)
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Oct 25, 2024
@MariusVanDerWijden @gzliudan
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
d316a8c 
…1559 chains (ethereum#23840)
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Oct 29, 2024
@MariusVanDerWijden @gzliudan
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
c1326a9 
…1559 chains (ethereum#23840)
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Oct 30, 2024
@MariusVanDerWijden @gzliudan
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
cf356d5 
…1559 chains (ethereum#23840)
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Oct 31, 2024
@MariusVanDerWijden @gzliudan
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
7ddc4b1 
…1559 chains (ethereum#23840)
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Oct 31, 2024
@MariusVanDerWijden @gzliudan
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
613e218 
…1559 chains (ethereum#23840)
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Nov 1, 2024
@MariusVanDerWijden @gzliudan
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
d2a10ef 
…1559 chains (ethereum#23840)
wanwiset25 pushed a commit to XinFinOrg/XDPoSChain that referenced this pull request Nov 13, 2024
@MariusVanDerWijden @wanwiset25
accounts/abi/bind/backends: make suggestGasPrice compatible with non-…
21a9c72 
…1559 chains (ethereum#23840)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

@gballet gballet Awaiting requested review from gballet gballet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.12
Development

Successfully merging this pull request may close these issues.
2 participants
@MariusVanDerWijden @holiman